Wait for writer response on Refresh #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending a Refresh message to Writer's refresh channel, if the state is "Succeeded" or "Failed", the Writer will update the sync channel when finished. Therefore there is a need to wait on sync channel on the Daemon side when sending "Succeeded" or "Failed". Signed-off-by: Fred Rolland <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
@fedepaol can you PTAL? |
| @@ -413,6 +413,8 @@ func (dn *Daemon) nodeStateSyncHandler(generation int64) error { | |||
| syncStatus: "Succeeded", | |||
| lastSyncError: "", | |||
| } | |||
| // wait for writer to refresh the status | |||
| <-dn.syncCh | |||
There was a problem hiding this comment.
IIUC as SyncCh is initialized with a zero capacity. then [1] will block until someone is trying to read from the channel.
nice catch here @rollandf
[1]
|
/test-all |
adrianchiris
approved these changes
Jul 10, 2022
e0ne
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a Refresh message to Writer's refresh channel,
if the state is "Succeeded" or "Failed", the Writer will update
the sync channel when finished.
Therefore there is a need to wait on sync channel on the Daemon side
when sending "Succeeded" or "Failed".
Signed-off-by: Fred Rolland [email protected]